[Bug 754696] matroskamux: delta unit on each buffer for audio only stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754696

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310882|none                        |reviewed
             status|                            |

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 310882
  --> https://bugzilla.gnome.org/attachment.cgi?id=310882
patch

I'm fine with the patch in principle, I'm just wondering about some specifics:

>@@ -3599,7 +3600,7 @@ gst_matroska_mux_write_data (GstMatroskaMux * mux, GstMatroskaPad * collect_pad,
> 
>   if (mux->doctype_version > 1 && !write_duration) {
>-    if (is_video_keyframe)
>+    if (is_video_keyframe || is_audio_only)
>       flags |= 0x80;
> 

Does this mean we will set the keyframe flag on the simpleblock header. Not
sure if that should ever be set for audio?

I thought the goal was to unset the DELTA_UNIT flag on the buffers, so
tcpserversink works nicely with audio-only streams?

I also wonder if the line below should not rather have

  gst_ebml_write_flush_cache (ebml, is_video_keyframe || is_audio_only,
buffer_timestamp);

?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.