[Bug 766973] Various warningfixes for OSX (10.9.5) compiling with Apple LLVM version 6.0

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766973

--- Comment #7 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #5)
> Comment on attachment 328679 [details] [review]
> avsamplevideosink
> 
> >+#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && \
> >+    MAC_OS_X_VERSION_MAX_ALLOWED >= 1010 && \
> >+    defined(MAC_OS_X_VERSION_MIN_REQUIRED) && \
> >+    MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4
> 
> this should be like that and not
> 
>  ... && (!defined(min_req) || (defined (min_req) && min_req <= 10_4))
> 
> right? (I have no opinion, just making sure..)

hgr
23:59 __tim: about your comment, I think the min-max version stuff is right,
because it must be 10.4 or lower AND it must be 10.1 or higher… :)

hgr
00:00 with OR 10.0 and 10.5 would both be valid

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.