[Bug 765528] gstmpdparser: GstUri changed unexpectedly within combine_urls()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765528

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328685|none                        |needs-work
             status|                            |

--- Comment #12 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 328685:
 --> (https://bugzilla.gnome.org/review?bug=765528&attachment=328685)

Code looks ok, but please provide a better commit message. Just check git log
of any module and you will see how to properly format the message.

Also, do you know which part of the spec mentions how these URL parameters
should be copied around? Couldn't find anything specific about this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.