[Bug 766419] videotimecode: Added support for SMPTE time code metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766419

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328270|reviewed                    |none
             status|                            |
 Attachment #328270|0                           |1
        is obsolete|                            |

--- Comment #12 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Created attachment 328786
  --> https://bugzilla.gnome.org/attachment.cgi?id=328786&action=edit
0001-videotimecode-Added-support-for-SMPTE-time-code-meta.patch

Thanks for your comments. Please review the updated version of the patch.

I also added a function to return the number of frames since daily jam,
according to internal feedback that I received. Otherwise the header file looks
OK to them too.

Just a few comments:
1) Drop frame cannot be detected based on the framerate. The same 30000/1001
and 60000/1001 framerates can exist in both drop-frame and non-drop-frame mode,
hence the flag.

2) I think that not having an enum simplifies the code. Right now, the only
place where arbitrary framerates are not supported are when calculating frames
(frames_since_daily_jam and add_frames) and the rest works. Integer framerates
are supported everywhere, as well as 30000/1001 and 60000/1001 in both
drop-frame and non-drop-frame modes. I decided to print a warning when
detecting an unsupported framerate, as well as document the supported ones,
instead of adding the complexity of an enum.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.