[Bug 767071] qtdemux: Various SEGMENT event related fixes, including regression fixes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue May 31 18:01:38 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=767071

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328807|none                        |reviewed
             status|                            |

--- Comment #10 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 328807:
 --> (https://bugzilla.gnome.org/review?bug=767071&attachment=328807)

dash should default to creating a 'dummy segment' that has its stop time
updated and increasing when new data is parsed. So what happens here is that
the segment isn't activated as the stop-time is still too small if you seek
forward to a fragment that isn't available yet.

Forwarding the segment directly for fragmented would work, but I think just
doing it when dummy_segment == true would cover more cases. Also it worries me
a bit that validate didn't catch any of these issues, will check what tests are
missing there.

With the exception of this one, all the other patches look good, so feel free
to push. Will report back when I investigate a bit on validate's side.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list