[Bug 767011] rawparse: new rawaudioparse element which deprecates audioparse and unalignedaudioparse

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767011

--- Comment #6 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 328712:
 --> (https://bugzilla.gnome.org/review?bug=767011&attachment=328712)

::: gst/rawparse/gstrawaudioparse.c
@@ +746,3 @@
+      GST_ERROR_OBJECT (parse,
+          "trying to push data even though current config is not ready");
+      flow_ret = GST_FLOW_ERROR;

In which case could this happen? If the src caps were rejected? Then it's
GST_FLOW_NOT_NEGOTIATED? Otherwise, do GST_ELEMENT_ERROR() before returning
GST_FLOW_ERROR.

@@ +866,3 @@
+
+  if (config->bpf == 0) {
+    GST_ERROR_OBJECT (parse, "trying to convert even though config->bpf is
0");

In which case can the ->bpf be 0? Shouldn't it always be valid either from the
sink caps or from the properties?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.