[Bug 767086] v4l2src pushes incomplete raw video buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767086

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328843|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 328843:
 --> (https://bugzilla.gnome.org/review?bug=767086&attachment=328843)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1738,3 @@
+            if (GST_VIDEO_INFO_FORMAT (&obj->info) != GST_VIDEO_FORMAT_ENCODED
+                && size < GST_VIDEO_INFO_SIZE (&obj->info)) {
+              goto buffer_corrupted;

Sounds safe, we should warn about the fact that this is a driver bug also. Want
to add that ? I'm fine with merging as-is too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.