[Bug 773709] player: Add get video thumbnail API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773709

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339007|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339007:
 --> (https://bugzilla.gnome.org/review?bug=773709&attachment=339007)

::: gst-libs/gst/player/gstplayer.c
@@ +4295,3 @@
+
+  width = gst_player_video_info_get_width (video_info);
+  height = gst_player_video_info_get_height (video_info);

Why? I think it would make more sense to add optional width/height parameters,
and otherwise leave them out of the caps below.

@@ +4300,3 @@
+    case GST_PLAYER_THUMBNAIL_RAW_RGB:
+      caps = gst_caps_new_simple ("video/x-raw",
+          "format", G_TYPE_STRING, "RGB",

Why RGB, that's usually very difficult to handle. Why not xRGB on big endian
and BGRx on little endian (that's what UI toolkits usually like)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.