[Bug 773473] kmssink: support display mode setting
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Nov 3 17:54:43 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=773473
--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 338403:
--> (https://bugzilla.gnome.org/review?bug=773473&attachment=338403)
This patch doesn't apply cleanly in master.
Anyway, I'm merging it manually. A couple comments, just nitpicking:
Some changes are just reindentations because 'if' nesting. I wonder if is it
possible to use the idiom
if (something)
goto label;
In my opinion is more readable if it is used wisely :D
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list