[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338410|none                        |reviewed
             status|                            |

--- Comment #19 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 338410:
 --> (https://bugzilla.gnome.org/review?bug=773473&attachment=338410)

::: sys/kms/gstkmsallocator.c
@@ +177,3 @@
+      GST_ERROR_OBJECT (allocator, "Unsupported color format");
+      free (kmsmem->bo);
+      return FALSE;

can make this a function?

get_bpp_from_format () for example

if it returns -1, destroy the bo

@@ +194,3 @@
+      break;
+    default:
+      arg.height = GST_VIDEO_INFO_HEIGHT (vinfo);

ditto

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.