[Bug 699077] videorate: Add a property to modify clip speed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=699077

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255125|needs-work                  |none
             status|                            |
 Attachment #255125|0                           |1
        is obsolete|                            |
 Attachment #255126|needs-work                  |none
             status|                            |
 Attachment #255126|0                           |1
        is obsolete|                            |
 Attachment #255127|reviewed                    |none
             status|                            |
 Attachment #255127|0                           |1
        is obsolete|                            |
 Attachment #255128|needs-work                  |none
             status|                            |
 Attachment #255128|0                           |1
        is obsolete|                            |

--- Comment #40 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 339067
  --> https://bugzilla.gnome.org/attachment.cgi?id=339067&action=edit
videorate: Add fixed rate property

I rebased those patches and merged them all in one single one,
I made minor changes in the tests and addressed all your comments:


(In reply to Sebastian Dröge (slomo) from comment #31)
> Review of attachment 255125 [details] [review]:
> 
> Generally looks good but the following. Forbid rate changes during states >
> READY maybe
> 

Added GST_PARAM_MUTABLE_READY which should be good enough.

(In reply to Sebastian Dröge (slomo) from comment #32)
> Review of attachment 255126 [details] [review]:
> 
> ::: tests/check/elements/videorate.c
> @@ +1044,3 @@
> +} RateInfo;
> +
> +static RateInfo rate_tests[] = {
> 
> not that it matters much in a test but make it const ;)

I enhanced sensibly the test and those structs are not const anymore

> @@ +1050,3 @@
> +        .expected_out = 25,
> +        .expected_drop = 8,
> +      .expected_dup = 0},
> 
> This is C99 syntax, use something C89 compatible (e.g. don't name fields)

Well, that syntax is used all around in that file...

(In reply to Sebastian Dröge (slomo) from comment #33)
> Review of attachment 255128 [details] [review]:
...
> @@ +1273,3 @@
>    tcase_add_loop_test (tc_chain, test_rate, 0, G_N_ELEMENTS (rate_tests));
>    tcase_add_test (tc_chain, test_query_duration);
> +  tcase_add_test (tc_chain, test_query_position);
> 
> Shouldn't this be a loop_test too?

DONE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.