[Bug 773912] basesink: Returns flushing on PLAYING->PAUSED if it can block in ->render

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773912

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Created attachment 339084
  --> https://bugzilla.gnome.org/attachment.cgi?id=339084&action=edit
NOMERGE: basesink: Don't call unlock() when going to PAUSED

This is an example patch that seems to work, we need to figure out
if we can just do it as-is or if we need ot add a flag so the subclasses can
say if they support it.

Instead of calling ->unlock() when going to PAUSED, just unlock the PREROLL
lock
before blocking in render and set it as prerolled.

The only downside I can see is that if the subclass doesn't stop itself in the
PAUSED state,
it could result in a new buffer being delivered to the sink after the sink has
claimed to have
prerolled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.