[Bug 773833] rtpL16depay, rtpL24depay: support depayloading in place

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773833

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
The problem is here:
https://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtp/gstrtpL16depay.c?id=752dd15c54238c389f676105867ff7815d623ced#n245

The payload buffer is retrieved and tried to be modified while the RTP buffer
is still referenced (the caller owns the reference). As such, modification
first needs to copy the whole payload. Fixing this will require API
changes/additions in GstRTPBaseDepayload.


For the other part, that should be easily solveable by checking (once when the
channel-layout is known) if any reordering has to happen, remember that and
just not do it if not needed.

Do you want to provide a patch for the second part?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.