[Bug 773891] rtpjitterbuffer: fix timer-reuse bug

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773891

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|---                         |FIXED

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 1a4393fb4d29a296b8c131041b46f25de8698c1b
Author: Havard Graff <havard.graff at gmail.com>
Date:   Thu Nov 3 15:03:59 2016 +0100

    rtpjitterbuffer: fix timer-reuse bug

    When doing rtx, the jitterbuffer will always add an rtx-timer for the next
    sequence number.

    In the case of the packet corresponding to that sequence number arriving,
    that same timer will be reused, and simply moved on to wait for the
    following sequence number etc.

    Once an rtx-timer expires (after all retries), it will be rescheduled as
    a lost-timer instead for the same sequence number.

    Now, if this particular sequence-number now arrives (after the timer has
    become a lost-timer), the reuse mechanism *should* now set a new
    rtx-timer for the next sequence number, but the bug is that it does
    not change the timer-type, and hence schedules a lost-timer for that
    following sequence number, with the result that you will have a very
    early lost-event for a packet that might still arrive, and you will
    never be able to send any rtx for this packet.

    Found by Erlend Graff - erlend at pexip.com

    https://bugzilla.gnome.org/show_bug.cgi?id=773891

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.