[Bug 773709] player: Add get video thumbnail API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773709

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339098|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339098:
 --> (https://bugzilla.gnome.org/review?bug=773709&attachment=339098)

Generally not too happy with the API yet, but I also don't have better
suggestions

::: gst-libs/gst/player/gstplayer.c
@@ +4302,3 @@
+      caps = gst_caps_new_simple ("video/x-raw",
+          "format", G_TYPE_STRING, "BGRx",
+          "pixel-aspect-ratio", GST_TYPE_FRACTION, 1, 1, NULL);

Usually it makes most sense to generate xRGB on big endian and BGRx on little
endian

@@ +4315,3 @@
+    default:
+      caps = gst_caps_new_simple ("video/x-raw",
+          "pixel-aspect-ratio", GST_TYPE_FRACTION, 1, 1, NULL);

Maybe the PAR should also be an (optional) parameter. For native it might make
sense to not rescale

::: gst-libs/gst/player/gstplayer.h
@@ +210,3 @@
+  GST_PLAYER_THUMBNAIL_RAW_NATIVE = 0,
+  GST_PLAYER_THUMBNAIL_RAW_XRGB,
+  GST_PLAYER_THUMBNAIL_RAW_BGRX,

Capitalization

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.