[Bug 774050] audiotestsrc: Improvements to the "ticks" waveform

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774050

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339244|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339244:
 --> (https://bugzilla.gnome.org/review?bug=774050&attachment=339244)

Maybe it makes sense to add a new element at some point for these complicated
testing sounds, instead of adding a million new properties that only apply to
some modes.

::: gst/audiotestsrc/gstaudiotestsrc.c
@@ +56,3 @@
+ *     100ms, and make every 20th tick a marker tick (meaning that every 2
seconds
+ *     there is a marker tick). This is useful for detecting large time
offsets
+ *     while still frequently triggering an oscilloscope.

Why did you decide on volume instead of frequency?

@@ +61,3 @@
+ *     Also, a "ramp" can be applied to the begin & end of ticks. The sudden
+ *     start of the sine tick is a discontinuity, even if the sine wave starts
+ *     at 0. The* resulting artifacts can often make it more difficult to use
the

Why *?

@@ +275,3 @@
+          "Distance between start of current and start of next tick, in
nanoseconds.",
+          1, G_MAXUINT64, DEFAULT_TIME_BETWEEN_TICKS,
+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

These two properties can conflict, right? If there are more sine periods in a
tick than the time between ticks...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.