[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #28 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Víctor Manuel Jáquez Leal from comment #16)
> Review of attachment 338403 [details] [review]:
> 
> ::: sys/kms/gstkmssink.c
> @@ +1177,3 @@
> +    waiting = TRUE;
> +    ret = drmModePageFlip (self->fd, self->crtc_id, fb_id,
> +        DRM_MODE_PAGE_FLIP_EVENT, &waiting);
> 
> is this possible if the driver doesn't support async page flip?

>From my understanding, async page flip and drmModePageFlip are not the same.
You should be able to always do a normal page flip. To trigger an async page
flip, you would set the DRM_MODE_PAGE_FLIP_ASYNC flag.

In fact, the handling of the vblank and page flip in the gst_kms_sink_sync()
function is the reason why I implemented gst_kms_page_flip(). I need the page
flip, but the imx drm does not have the async page flip capability. Maybe if
this is sorted out, I could just use the gst_kms_sink_sync() function.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.