[Bug 774178] smoothstreaming: support live seeking and reporting the live duration

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774178

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339432|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339432:
 --> (https://bugzilla.gnome.org/review?bug=774178&attachment=339432)

Generally makes sense but you seemed to have done some last minute changes that
broke things before submitting the patch :)

::: ext/smoothstreaming/gstmssmanifest.c
@@ +1484,3 @@
+        gst_mss_manifest_get_dvr_window_length_clock_time (manifest);
+
+    if (GST_CLOCK_TIME_IS_VALID (dvr_window) && stop - start > dvr_window) {

You compare pointers here, start and stop are pointers

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.