[Bug 774213] vaapivideomemory: lock at mapping and unmapping

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 10 14:26:09 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774213

--- Comment #1 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Created attachment 339491
  --> https://bugzilla.gnome.org/attachment.cgi?id=339491&action=edit
vaapivideomemory: refactor vaapi memory unmapping

There were duplicated code in gst_video_meta_unmap_vaapi_memory() and
gst_vaapi_video_memory_unmap() when unmapping.

This patch refactors both methods adding the common function
unmap_vaapi_memory(). This also ensures, if direct rendering is enabled, it
is correctly reset.

Additionally, only when mapping flag has the WRITE bit, it set the image as
current, which was done in gst_video_meta_map_vaapi_memory() but no in
gst_vaapi_video_memory_map().

In order to make this, the mapping flags were required, so instead of
overloading mem_unmap() virtual function, mem_unmap_full() is overloaded.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list