[Bug 770953] gstclock: segmentation fault when unschedule

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770953

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335121|none                        |needs-work
             status|                            |

--- Comment #20 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 335121
  --> https://bugzilla.gnome.org/attachment.cgi?id=335121
gstclock: Keep weak reference to underlying clock

>--- a/gst/gstclock.c
>+++ b/gst/gstclock.c
>@@ -247,7 +247,10 @@ gst_clock_entry_new (GstClock * clock, GstClockTime time,
>       "created entry %p, time %" GST_TIME_FORMAT, entry, GST_TIME_ARGS (time));
> 
>   entry->refcount = 1;
>+#ifndef GST_DISABLE_DEPRECATED
>   entry->clock = clock;
>+#endif
>+  g_weak_ref_init (&entry->ABI.clock, clock);

Not sure this is right, we should keep setting it for backwards compat. I think
you probably wanted a

#ifndef GST_REMOVE_DEPRECATED

here instead (and also in the header).


> /**
>+ * gst_clock_id_get_clock:
>+ * @id: a #GstClockID
>+ *
>+ * This function returns the underlying clock.
>+ *
>+ * Returns: (transfer full) (nullable): a #GstClock or %NULL when the
>+ *     underlying clock has been freed.  Unref after usage.
>+ *
>+ * MT safe.

Please add a Since: 1.12  here and for uses_clock()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.