[Bug 755036] mssdemux: improved live playback support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755036

--- Comment #15 from Philippe Normand <philn at igalia.com> ---
(In reply to Matthew Waters (ystreet00) from comment #13)

> @@ +1117,3 @@
> +    fragment = stream->current_fragment->data;
> +    if (fragment->time <= prev_fragment->time) {
> +      while (fragment->time <= prev_fragment->time) {
> 
> double condition without an else on the if seems a little pointless no?
> 
> Also, what exactly is the while loop meant to solve?
> 
> When aren't the fragments that you're iterating over, not in order?
> 
> In any case, this seems like it should be a separate patch.

This is an issue introduced by the patch, the fragment timestamp continuity
isn't respected in the parsed tfrf box.

So this loop isn't needed at all and we should instead compare the fragment
timestamp parsed from the tfrf box with the timestamp of the last fragment of
the queue.

I'll update the patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.