[Bug 774196] mpdparser: Fix timestamp setting on fragment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774196

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339678|none                        |reviewed
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339678:
 --> (https://bugzilla.gnome.org/review?bug=774196&attachment=339678)

::: gst/isomp4/qtdemux.c
@@ +2166,3 @@
+       * because what demux could know is about upto current moof,
+       * and demux has limited understanding of total presentation timeline */
+      if (!(demux->upstream_format_is_time && demux->fragmented)) {

Why would we only want this on fragmented streams? I think we actually want
this on all streams, no? If upstream is in TIME, there's probably a reason for
that and we should not just ignore that information.

Or am I missing something here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.