[Bug 644776] Macro to check check mutability in set_property functions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Nov 14 09:13:33 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=644776

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339704|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339704:
 --> (https://bugzilla.gnome.org/review?bug=644776&attachment=339704)

Looks good but

::: gst/gstelement.h
@@ +645,3 @@
+
+/**
+ * GST_ELEMENT_CHECK_PROPERTY_SET_MUTABILITY_UNLOCKED:

Elsewhere in our code, the unlocked variants are the ones that assume outside
to take the lock. And the non-unlocked variants are the ones that take the lock
before calling the unlocked variant.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list