[Bug 774223] opencv: move base opencv filter class and utilities to gst-libs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774223

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis at debethencourt.com

--- Comment #2 from Luis de Bethencourt <luis at debethencourt.com> ---
This is a great idea!

You are missing something to be able to use <gst/video/video.h> in
gstopencvutils.h
In file included from gstopencvutils.cpp:26:0:
gstopencvutils.h:30:29: fatal error: gst/video/video.h: No such file or
directory
compilation terminated.


A few small fixes as well.

-libgstopencv_la_CFLAGS = $(GST_PLUGINS_BASE_CFLAGS) $(GST_BASE_CFLAGS) \
-       $(GST_CFLAGS) $(OPENCV_CFLAGS) \
The change here does nothing but restructure the content, please keep it as it
is to keep a clean git history.

Related to the above. When you add one element at the beginning of the list,
keep the rest structured as before. If there are multiple in one line it is
because it is easier to read.

Keep the lines in gst-libs/gst/opencv/Makefile.am inside the 80 character
limit.

#libgstopencv_ at GST_API_VERSION@_la_CFLAGS
Why the commented out section in gst-libs/gst/opencv/Makefile.am?

+EXTRA_DIST =
adds a white line

Add the bugzilla URL in the last line of the commit, since we now have a bug
thread.

Maybe mention that this patch requires cleaning the autotools crumbs of the
previous builds to work.

Thanks :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.