[Bug 774409] New: tests/jitterbuffer: Major refactoring and cleanups
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Nov 14 14:37:31 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=774409
Bug ID: 774409
Summary: tests/jitterbuffer: Major refactoring and cleanups
Classification: Platform
Product: GStreamer
Version: git master
OS: All
Status: NEW
Severity: minor
Priority: Normal
Component: gst-plugins-good
Assignee: gstreamer-bugs at lists.freedesktop.org
Reporter: havard.graff at gmail.com
QA Contact: gstreamer-bugs at lists.freedesktop.org
CC: gstreamer at pexip.com
GNOME version: ---
Created attachment 339806
--> https://bugzilla.gnome.org/attachment.cgi?id=339806&action=edit
refactorings
* Changed PCMU->TEST for common macros
* Changed verify-functions (lost & rtx) into macros.
* Remove option to add marker-bit for test-buffers (not used anywhere)
* Add new push_test_buffer function that makes sure there are correlation
between dts and the time on the clock. (classic test-mistake)
* Established a generic starting-point for tests with the
construct_deterministic_initial_state function and use it where
applicable, which removes lots of "boilerplate" everywhere.
* Add basic lost-event test
* Remove as much "magic constants" as possible.
* Remove 3 tests that no longer are testing anything that others don't,
and was completely unmaintainable.
* Remove unnecessary use of the testclock
* Verify each test is testing what it actually says it does (and modify
where it doesn't)
In general, make the tests much smaller, better, more maintainable and
readable.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list