[Bug 774293] msvc: fix some warnings, disable others

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774293

--- Comment #15 from Scott D Phillips <scott.d.phillips at intel.com> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> Review of attachment 339656 [details] [review]:
> 
> ::: meson.build
> @@ +17,3 @@
> +  add_global_arguments(
> +      '/wd4018', # implicit signed/unsigned conversion
> +      '/wd4090', # implicit const conversion
> 
> This is non-const to const conversion? Or also the other way around?

This is const to non-const. I think it is mostly in code like:

> static const Something *a;
> if (g_once_init_enter (a)) {
>   a = ...

I'm not sure why gcc doesn't care about losing the const there. If you think it
better to keep those warnings on I can take a look into it what changes would
be required.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.