[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

--- Comment #17 from John Poet <jppoet at gmail.com> ---
The apparent data corruption was because of a typo in
gst_ffmpegvidenc_handle_vanc()

  GstVANCMeta *vmeta = (GstVANCMeta *) meta;

should have been

  GstVANCMeta *vmeta = (GstVANCMeta *) *meta;

In gst_decklink_video_src_create() I discovered that moving 

  gst_buffer_add_video_time_code_meta (*buffer, f->tc);

down below the routine which add GstVANCMeta fixes the problem with the VANC
meta now showing up at the receiving end.  Does this mean that adding the
time_code_meta needs to be done last?

I have update all three patches with new versions.  These mostly address your
concerns.  Your remaining comments mostly have to do with commenting variables
and such.  I will try to address those, but I have to admit that most of the
low-level VANC code is not mine, and I am adapting it from work by
ex-coworkers.  I will see if I can figure out why they did some of the stuff
they did.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.