[Bug 774293] msvc: fix some warnings, disable others

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 15 12:20:35 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774293

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339859|none                        |needs-work
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339859:
 --> (https://bugzilla.gnome.org/review?bug=774293&attachment=339859)

::: gst/gstbuffer.c
@@ +2482,3 @@
   static const GstMetaInfo *meta_info = NULL;

+  if (g_once_init_enter ((GstMetaInfo **) & meta_info)) {

I don't think that is correct. The const at the variable declaration should go
away. It is *not* const, otherwise it would always stay NULL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list