[Bug 774293] msvc: fix some warnings, disable others

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 15 12:44:23 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774293

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339864|needs-work                  |accepted-commit_now
             status|                            |

--- Comment #37 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 339864:
 --> (https://bugzilla.gnome.org/review?bug=774293&attachment=339864)

::: gst-libs/gst/codecparsers/gstjpegparser.c
@@ +577,3 @@
   for (i = 0; i < num_entries; i++)
     sorted_entries[i] = &entries[i];
+  qsort ((void *) sorted_entries, num_entries, sizeof (sorted_entries[0]),

No, the variable declaration is correct.

const GstJpegHuffmanTableEntry *sorted_entries[256]

is a writable non-const array of pointers to const GstJpegHuffmanTableEntry.

::: gst/id3tag/id3tag.c
@@ -460,3 @@
   }

-  g_free (strings);

No, it's not :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list