[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339847|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339847:
 --> (https://bugzilla.gnome.org/review?bug=773863&attachment=339847)

Basically same comments as last time in this one

::: sys/decklink/gstdecklinkvanc.cpp
@@ +265,3 @@
+{
+  guint8 *vanc[50];
+  const int vanc_cnt = sizeof(vanc) / sizeof(guint8 *);

G_N_ELEMENTS(vanc)

@@ +294,3 @@
+
+  BMDPixelFormat fmt = vanc_frame->GetPixelFormat();
+  std::vector<guint16> tmp_data;

Don't use a C++ vector, basically same comments as last time here :)

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +707,1 @@
   gst_buffer_add_video_time_code_meta (*buffer, f->tc);

How many vanc metas are added? Adding a meta to a buffer is literally just
appending an item to a linked list. In any order, none of the things should
disappear.

Can you check in the gst_buffer_add_meta() code what goes wrong there?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.