[Bug 774463] mpdparser: Allows invalid URI within xlink attributes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774463

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339918|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339918:
 --> (https://bugzilla.gnome.org/review?bug=774463&attachment=339918)

::: ext/dash/gstmpdparser.c
@@ -4246,3 @@
         period_node->xlink_href, err->message);
     g_clear_error (&err);
-    *error = TRUE;

This means that error is never ever set to anything. Should just be removed
from the parameters then

@@ +4309,3 @@
+  if (new_periods) {
+    g_list_free_full (new_periods,
+        (GDestroyNotify) gst_mpdparser_free_period_node);

Shouldn't we keep all periods that were successfully parsed? Or is the spec
saying to discard all if one can't be parsed?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.