[Bug 747442] tsdemux: lacks locking in the seeking code

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 15 14:14:36 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=747442

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at noraisin.net

--- Comment #1 from Jan Schmidt <thaytan at noraisin.net> ---
This comment only seems valid when operating in push mode. In pull mode, the
base class will shut down streaming and acquire the stream lock before asking
the sub-class to handle the seek.

In push mode, there's a potential problems because gst_ts_demux_do_seek() is
called without the stream lock and could crash if the program / streams list
changes simultaneously. 

There are more fundamental problems with that seek handling in push mode
though, in that it modifies the state of the streams and segments and things as
if the seek had already happened, when the event isn't sent upstream until
after, and indeed may then remain pending for some time.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list