[Bug 774533] Remove vmnc plugin
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Nov 16 18:50:30 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=774533
--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 4cb1bcf1422bbcd79c0f683edb7ee85e3f7a31fe
Author: Sebastian Dröge <sebastian at centricular.com>
Date: Wed Nov 16 20:41:39 2016 +0200
vmncdec: Sanity-check width/height before using it
We will allocate a screen area of width*height*bpp bytes, however this
calculation can easily overflow if too high width or height are given
inside the stream. Nonetheless we would just assume that enough memory
was allocated, try to fill it and overwrite as much memory as wanted.
Also allocate the screen area filled with zeroes to ensure that we start
with full-black and not any random (or not so random) data.
https://scarybeastsecurity.blogspot.gr/2016/11/0day-poc-risky-design-decisions-in.html
Ideally we should just remove this plugin in favour of the one in
gst-libav, which generally seems to be of better code quality.
https://bugzilla.gnome.org/show_bug.cgi?id=774533
commit 088aebfda90f328f4c103cd20224db4f2ff021dc
Author: Sebastian Dröge <sebastian at centricular.com>
Date: Wed Nov 16 20:48:28 2016 +0200
riff: Extract bpp from the strf for vnmc
Needed for avdec_vnmc to work.
Considering all this, the main "advantage" of our decoder seems to be that it
extracts the video format information from the stream, while the ffmpeg one
requires them to be given from the outside in the AVI container.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list