[Bug 774588] video-info: Catch overflows in the video frame size calculation

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 16 19:14:51 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774588

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Created attachment 340071
  --> https://bugzilla.gnome.org/attachment.cgi?id=340071&action=edit
video-info: Catch overflows in the video frame size calculation

A moderate maximum size that we can handle is 16384x16384, which allows
for 64 bit per pixel without overflow. This is the same number as used
by ffmpeg.

This wouldn't have prevented
https://scarybeastsecurity.blogspot.gr/2016/11/0day-poc-risky-design-decisions-in.html
unfortunately as gst_video_info_set_format() can't return a failure
(neither can align()) but would've given a warning at least.

We would have to check afterwards with e.g. a newly added
gst_video_info_is_valid().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list