[Bug 773172] typefinding: mis-detects iTunes artwork cache ( .itc ) file as audio/mpeg

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773172

--- Comment #7 from Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> ---
(In reply to Tim-Philipp Müller from comment #6)
> Comment on attachment 340089 [details] [review]
> add typefinder for Apple/iTunes itc artwork files
> 
> Thanks for working on this.
> 
> >+/*** application/itc ***/
> >+static GstStaticCaps itc_caps = GST_STATIC_CAPS ("application/itc");
> >+#define ITC_CAPS (gst_static_caps_get(&itc_caps))
> 
> OOC, is this a media type that is used elsewhere, or made-up?

Made up

> [...] 
> What is the meaning of these 'preamble' bytes? Do they always exist once,
> twice, three times? (and in a row?)

Happens 3 times in a row after the magic on all samples.

> 
> My gut feeling is that the probability advertised here is a bit too high for
> the kind of data checked.

It can be extended a bit to incorporate more checks. Will post an updated
patch latter. Thanks for taking a look.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.