[Bug 755329] Race condition around finish_unprepare

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755329

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338497|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338497:
 --> (https://bugzilla.gnome.org/review?bug=755329&attachment=338497)

::: gst/rtsp-server/rtsp-media.c
@@ +3021,1 @@
     finish_unprepare (media);

AFAIU this has the problem that multiple calls to unprepare will not work well.

What would happen is that the second call would immediately go here and call
finish_unprepare()... which is not really what you want (the we might have to
wait for EOS first for example).


Maybe if we're currently unpreparing, just do nothing at all here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.