[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339982|none                        |needs-work
             status|                            |

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339982:
 --> (https://bugzilla.gnome.org/review?bug=773863&attachment=339982)

Seems good to me, just minor things and need of documentation :)

::: gst-libs/gst/vanc/gstvancmeta.c
@@ +100,3 @@
+GstVANCMeta *
+gst_buffer_add_vanc_meta (GstBuffer * buffer, gint data_id, gint dbn_sdid,
+    const guint16 * data, gsize size, guint16 checksum)

Needs documentation, e.g. to specify that the size is in 16 bit words, not
bytes

@@ +104,3 @@
+  GstVANCMeta *vmeta;
+
+  g_return_val_if_fail (GST_IS_BUFFER (buffer), NULL);

g_return_val_if_fail (data != NULL, NULL)
g_return_val_if_fail (size == 0, NULL)

::: gst-libs/gst/vanc/gstvancmeta.h
@@ +55,3 @@
+
+GstVANCMeta * gst_buffer_add_vanc_meta (GstBuffer * buffer,
+                                        gint did, gint dbn_sdid,

"did" while the field in the meta is called "data_id"

@@ +64,3 @@
+#if 0
+#define gst_buffer_get_vanc_meta(b)                             \
+  ((VANCMeta*)gst_buffer_get_meta((b), GST_VANC_META_API_TYPE))

Why commented out? Might make sense to add API that gets the number of VANC
metas, and then allows getting them by index. Or some kind of iterator API that
only gives VANCs

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.