[Bug 774629] decklinkvideosrc: Issue "no signal" warnings

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 17 16:29:07 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774629

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340141|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340141:
 --> (https://bugzilla.gnome.org/review?bug=774629&attachment=340141)

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +660,3 @@
+  flags = f->frame->GetFlags();
+  if (flags & bmdFrameHasNoInputSource) {
+    if (self->no_signal == FALSE) {

Don't compare booleans with ==

@@ +667,3 @@
+  } else {
+    if (self->no_signal) {
+      self->no_signal = FALSE;

You also need to reset it to FALSE (as in init()) whenever the element is
restarted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list