[Bug 774416] RTSP digest Authentification for gst-rtsp-server

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774416

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339993:
 --> (https://bugzilla.gnome.org/review?bug=774416&attachment=339993)

::: gst/rtsp-server/rtsp-auth.c
@@ +730,3 @@
+auth_digest_compute_response (const gchar * method,
+    const gchar * uri, const gchar * hex_a1, const gchar * nonce,
+    gchar response[33])

I would add a gst_rtsp_generate_digest_auth_response(algorithm (=="md5",
method, real, username, password, uri, nonce)

@@ +837,3 @@
+      response = g_strdup (value);
+    else if (!uri && strcmp (item, "uri") == 0 && value)
+      uri = g_strdup (value);

And for this a gst_rtsp_message_parse_authorization(request, &method, &tokens)

Where tokens is a struct {char *key; char *value} (do we have something
reusable for that?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.