[Bug 773712] isomp4: Add support for FLAC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773712

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340139|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340139:
 --> (https://bugzilla.gnome.org/review?bug=773712&attachment=340139)

::: gst/isomp4/qtdemux.c
@@ +10940,3 @@
+                 * METADATA_BLOCK_STREAMINFO block */
+                stream->rate =
+                    (QT_UINT32 (metadata_blocks + 14) >> 12) & 0xFFFFF;

There are no checks that this much memory is available. Also in the other array
accesses above.

Is the sample rate guaranteed to be given in the STREAMINFO block, or can it be
0 and only be provided via the container?


You might also want to put channel, samplerate and other information (as
flacparse does) into the caps

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.