[Bug 771830] There is no time out in idle connection RTSP server

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771830

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 336087
  --> https://bugzilla.gnome.org/attachment.cgi?id=336087
Updated timout patch

Looks mostly fine to me.

- please run gst-indent over the code, there are a few minor code style issues

>+  /* Setting up a timeout for the RTSP control channel until a session
>+   * is up where it is handling timeouts. */
>+  ...
>+  priv->rtsp_ctrl_timeout_id = g_timeout_add_seconds(RTSP_CTRL_CB_INTERVAL,
>+      rtsp_ctrl_timeout_cb, client);

If I'm not mistaken this adds the timeout to the default main context, but I
don't think we can assume that the default main context will be iterated.
Shouldn't we be using whatever main context the client was attached to?
(priv->watch_context ?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.