[Bug 773712] isomp4: Add support for FLAC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773712

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to David Evans from comment #4)
> Thanks for such a quick initial review.
> 
> > There are no checks that this much memory is available. Also in the other array accesses above.
> 
> The available data length is extracted from the dfla box header and checked
> to be at least a minimum valid fifty bytes. After that, all array accesses
> are either programmatically limited or hard-coded to values less than the
> reported length. Looking at several other box parsers above (eg alac, wma),
> they operate in an identical way. Should I be approaching this differently?

Seems ok then, the dfla box length is already validated when parsing the box
earlier. Seems I misread :)

> > You might also want to put channel, samplerate and other information (as flacparse does) into the caps
> 
> These values are extracted by the stsd parser and added to the caps
> automatically in gst_qtdemux_configure_stream so they do end up on the final
> caps. The isoflac spec requires that the STREAMINFO values match the stsd
> values so there didn't seem any point doing extra work here. I am of course
> happy to do this explicitly here if you wish, or have I missed the point?
> 
> > Is the sample rate guaranteed to be given in the STREAMINFO block, or can it be 0 and only be provided via the container?
> 
> 0 is called out explicitly invalid in the FLAC format specification - it
> must be supplied and correct in the STREAMINFO.

Seems good then

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.