[Bug 774566] matroskaparse: error out on last buffer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774566

Nicola <lists at svrinformatica.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340257|0                           |1
        is obsolete|                            |

--- Comment #21 from Nicola <lists at svrinformatica.it> ---
Created attachment 340295
  --> https://bugzilla.gnome.org/attachment.cgi?id=340295&action=edit
updated patch

new patch, works fine with the original file and tested with a file with broken
data in the middle generated this way:

dd if=/tmp/broken.mkv of=/tmp/1.mkv bs=208748 count=1
dd if=/dev/zero of=/tmp/random bs=19 count=1
dd if=/tmp/broken.mkv of=/tmp/2.mkv skip=208748 bs=1
cat /tmp/random >> /tmp/1.mkv
cat /tmp/2.mkv >> /tmp/1.mkv

the original file has a cluster at offset 208749

matroskaparse matroska-parse.c:3059:gst_matroska_parse_chain:<matroskaparse0>
Offset 208749, Element id 0x1f43b675, size 18446744073709551615, needed 12,
available 147

if I change bs here:

dd if=/dev/zero of=/tmp/random bs=19 count=1

to a value > 65536 we exceed the threshold and we get an unrecoverable error,

please review

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.