[Bug 684790] isomp4/qtdemux: Whenever a moov atom is found, restart the demuxer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=684790

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340289|none                        |reviewed
             status|                            |

--- Comment #9 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 340289:
 --> (https://bugzilla.gnome.org/review?bug=684790&attachment=340289)

Took a quick look, overall code looks fine. Will try to run it later today.

Besides DASH track_Id changes, what other cases would be covered here? What
should we do with pull-mode?

Should we also test that it works by sending sequentially 2 independent moov
files? Just checking what should we add together with this to validate media
tests.

This change looks simple enough that we could do it without GstStreams API (as
it should work anyway) and do the porting on a separate patch to make reviewing
and spotting regressions easier.

::: gst/isomp4/qtdemux.h
@@ +235,3 @@
+
+  /* Whether demux needs to re-expose or remove srcpads */
+  gboolean need_reconfigure;

Reconfigure has a certain meaning in gstreamer related to the RECONFIGURE
event, maybe we want something like "has_new_headers" or "has_new_moov"?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.