[Bug 774566] matroskaparse: error out on last buffer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Nov 21 07:47:32 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774566

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340295:
 --> (https://bugzilla.gnome.org/review?bug=774566&attachment=340295)

Looks all good except for:

::: gst/matroska/matroska-parse.c
@@ +3035,3 @@
+       */
+      gint64 bytes_scanned;
+      const guint max_threshold = 64 * 1024;

Why 64kbyte? Looks a bit too small. I would've said something like ~2MB maybe

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list