[Bug 774657] add proxy control binding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774657

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340208|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340208:
 --> (https://bugzilla.gnome.org/review?bug=774657&attachment=340208)

Generally makes sense, but:

::: libs/gst/controller/gstproxycontrolbinding.c
@@ +167,3 @@
+      "name", property_name, NULL);
+
+  cb->ref_object = ref_object;

Should probably store a new reference?

@@ +168,3 @@
+
+  cb->ref_object = ref_object;
+  cb->property_name = ref_property_name;

... and g_strdup() this one?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.