[Bug 774830] uri: Add new uri API to get URI fragment as table

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774830

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340490|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340490:
 --> (https://bugzilla.gnome.org/review?bug=774830&attachment=340490)

::: gst/gsturi.c
@@ +2822,3 @@
+ */
+GHashTable *
+gst_uri_get_fragment_table (const GstUri * uri)

As this is not defined in the URI spec itself, this should specifically mention
what it's doing and based on.

Maybe something like get_media_fragment_table()? Should also mention the link
to the spec in the docs.

@@ +2828,3 @@
+  if (!uri->fragment)
+    return NULL;
+  return _gst_uri_string_to_table (uri->fragment, "&", "=", TRUE, TRUE);

Is that really enough? I didn't read the spec but that seems a bit simple :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.