[Bug 774846] asfdemux: Timeouts with corrupted files

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774846

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340525|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 340525:
 --> (https://bugzilla.gnome.org/review?bug=774846&attachment=340525)

::: gst/asfdemux/gstasfdemux.c
@@ +2086,3 @@
      * send any pending payloads before sending EOS */
     if (!demux->activated_streams)
+      flow = gst_asf_demux_push_complete_payloads (demux, TRUE);

And someone is actually checking "flow"?

@@ +2133,3 @@
     /* For the error cases */
+    if (flow == GST_FLOW_EOS && !demux->activated_streams)
+      GST_ELEMENT_FLOW_ERROR (demux, flow);

We usually use WRONG_TYPE here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.