[Bug 773912] fdsink: Returns flushing on PLAYING->PAUSED if it can block in ->render

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773912

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.10.1

--- Comment #9 from Olivier Crête <olivier.crete at ocrete.ca> ---
Merged, I'll open new bugs for the other elements.

commit e6febb5bc1a003b7b6d702675c6a83e9565e0ae6
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Fri Nov 4 18:54:10 2016 -0400

    basesink: Document the interaction between unlock() and wait_preroll()

    This was totally non-obvious, the kind of big problem is that subclasses
must
    be able to unblock their streaming thread and continue exactly where they
left off
    on unpause!

    https://bugzilla.gnome.org/show_bug.cgi?id=773912

commit 5216322d39448ed61c86bb1b3dd9c8c5e6feccf3
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Fri Nov 4 18:46:45 2016 -0400

    fdsink: Block in preroll_wait on unlock

    The correct behaviour of anything stuck in the ->render() function
    between ->unlock() and ->unlock_stop() is to call
    gst_base_sink_wait_preroll() and only return an error if this returns an
    error, otherwise, it must continue where it left off!

    https://bugzilla.gnome.org/show_bug.cgi?id=773912

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.