[Bug 775014] v4l2src buffer leak, race condition sending EOS from another thread

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 24 15:29:59 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=775014

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 340687:
 --> (https://bugzilla.gnome.org/review?bug=775014&attachment=340687)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1706,2 @@
   if (GST_BUFFER_POOL_IS_FLUSHING (pool))
     return GST_FLOW_FLUSHING;

Would it also work to move this assertion after the flushing check ? Otherwise,
I'm fine with this change. I have notice that this assertion was popping in
various error conditions too (including unplugging a USB camera).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list